Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: feature "hash" not no_std compatible #29

Open
tdelabro opened this issue Dec 21, 2023 · 2 comments
Open

bug: feature "hash" not no_std compatible #29

tdelabro opened this issue Dec 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@tdelabro
Copy link
Collaborator

Adding the feature "hash" to dependency starknet-types-core in ensure_no_std/Cargo.tom results in a failure to build.
This is weird because the code behind the "hash" feature flag doesn't import anything from "std" and the only dep it add to the equation is labdaclass-crypto, wich is supposed to be no-std

@tdelabro
Copy link
Collaborator Author

tdelabro commented Dec 22, 2023

@pefontana @Oppen do you know something about that? Do you want to work on it yourselves or should I put someone onto it?

@Oppen
Copy link
Contributor

Oppen commented Dec 27, 2023

I think the culprit is an oversight in lambdaworks-crypto deps:

[dependencies]
lambdaworks-math.workspace = true
sha3 = "0.10"
sha2 = "0.10"
thiserror = "1.0.38"
serde = { version = "1.0", features = ["derive"] }
rayon = { version = "1.8.0", optional = true }

None of them is disabling the default features, so thiserror and serde, at least, are assuming std IIUC. This should be fixed in lambdaworks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants