Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): add no_std support to crypto #734

Closed
wants to merge 1 commit into from

Conversation

tdelabro
Copy link
Contributor

@tdelabro tdelabro commented Dec 28, 2023

no_std support for crypto crate

Description

Description of the pull request changes and motivation.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

Oppen
Oppen previously approved these changes Dec 28, 2023
Copy link
Contributor

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oppen
Oppen previously approved these changes Dec 28, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f96448c) 95.63% compared to head (34406e0) 95.62%.

Files Patch % Lines
crypto/src/merkle_tree/merkle.rs 40.00% 3 Missing ⚠️
math/src/msm/naive.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   95.63%   95.62%   -0.01%     
==========================================
  Files         136      136              
  Lines       30882    30885       +3     
==========================================
  Hits        29533    29533              
- Misses       1349     1352       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdelabro
Copy link
Contributor Author

superseded by #736

@tdelabro tdelabro closed this Dec 29, 2023
@tdelabro tdelabro deleted the add-no_std-to-crypto branch January 3, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants