-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve poseidon API #109
base: main
Are you sure you want to change the base?
Conversation
@varun-doshi need any help? |
I'm not sure how to go about hash_single for Pedersen...since it's now in the trait for both Poseidon and Pedersen hence it needs to be implemented as well. I can open this PR for review if that'll help? |
@varun-doshi I think the pedersen hash_single impl should be |
79ebfa0
to
54ab01a
Compare
@varun-doshi let's go with Add the first example to the |
54ab01a
to
997aabb
Compare
997aabb
to
0cc7dbc
Compare
0cc7dbc
to
4483284
Compare
Pull Request type
What is the current behavior?
StarkHash trait does have
hash_single
funcitonResolves: #107
What is the new behavior?
hash_single
functionDoes this introduce a breaking change?
No
Other information
This results in Pedersen needing to implement
hash_single
as well. Currently, it is set as todo!