Dori/restore sizeof #157
Merged
Dori/restore sizeof #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c50ed21.
Signed-off-by: Dori Medini <dori@starkware.co>
dorimedini-starkware
requested review from
dan-starkware,
gabrielbosio and
pefontana
as code owners
Yoni-Starkware
approved these changes
Sep 15, 2025
dafnamatsry
approved these changes
Sep 15, 2025
Merged
dan-starkware
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch: restore
SizeOfforFelt(temporarily)What is the current behavior?
No implementation of
size_of::SizeOfonFeltsince PR#140; revert this change to publish v0.2.1, and then revert and publish 0.2.2Resolves: lack of
SizeOfimplWhat is the new behavior?
SizeOfforFeltis restoredDoes this introduce a breaking change?
Will break conflicting implementations of a
SizeOftrait, if they existOther information