feat: add ChainId type #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested review from
dan-starkware,
gabrielbosio and
pefontana
as code owners
tdelabro
force-pushed
the
feat-chain-id
branch
2 times, most recently
from
4133d80 to
037d445
Compare
tdelabro
force-pushed
the
feat-chain-id
branch
from
037d445 to
ef2ad22
Compare
tdelabro
force-pushed
the
feat-chain-id
branch
from
f687ffe to
d8e659e
Compare
tdelabro
force-pushed
the
feat-chain-id
branch
from
b6b62ab to
d5b2972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the type
ChainIdWhat is the new behavior?
The
ChainIdtype allows for representing the two starknet chains, SN_MAIN and SN_SEPOLIA.It offers type conversion from and into Felt, ShortString, String.
A new Rust feature
devnetallows adding a custom local devnet with any validShortStringas name (eg.SN_DEVNET).Also, add a new
short_string!macro, for compile-time creation ofShortStringsDoes this introduce a breaking change?
Yes. Replace
TryFrom<&str> for ShortStringbyFromStr for ShortString.More idiomatic