Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Transaction enum's variant name are too verbose #1706

Open
tdelabro opened this issue Mar 21, 2024 · 1 comment · May be fixed by starkware-libs/sequencer#222
Open

Transaction enum's variant name are too verbose #1706

tdelabro opened this issue Mar 21, 2024 · 1 comment · May be fixed by starkware-libs/sequencer#222

Comments

@tdelabro
Copy link
Contributor

pub enum Transaction {
    AccountTransaction(AccountTransaction),
    L1HandlerTransaction(L1HandlerTransaction),
}

could be

pub enum Transaction {
    Account(AccountTransaction),
    L1Handler(L1HandlerTransaction),
}

without losing any information.

@tdelabro
Copy link
Contributor Author

pub enum AccountTransaction {
    Declare(DeclareTransaction),
    DeployAccount(DeployAccountTransaction),
    Invoke(InvokeTransaction),
}

is already doing it right

gswirski pushed a commit to reilabs/blockifier that referenced this issue Jun 26, 2024
Co-authored-by: kariy <kariy@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant