Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

test: remove the test util create_account_tx_test_state #1606

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Mar 1, 2024

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)


crates/blockifier/src/transaction/transactions_test.rs line 1933 at r1 (raw file):

    let execute_calldata = Calldata(
        [
            vec![StarkFelt::from(test_contract.get_instance_address(0))],

can you use into() or stark_felt!?

Code quote:

StarkFelt::from(test_contract.get_instance_address(0))

@ArniStarkware ArniStarkware force-pushed the arni/maintainance/remove_instances_of_trivial_entry_point/pt_2 branch from 296f749 to 28146e1 Compare March 1, 2024 21:54
@ArniStarkware ArniStarkware force-pushed the arni/maintainance/remove_create_account_tx_test_state branch from bb8c114 to e2b0591 Compare March 1, 2024 21:58
@ArniStarkware
Copy link
Contributor Author

crates/blockifier/src/transaction/transactions_test.rs line 1933 at r1 (raw file):

Previously, dorimedini-starkware wrote…

can you use into() or stark_felt!?

Done.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.16%. Comparing base (c5ff20a) to head (de11260).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1606   +/-   ##
=======================================
  Coverage   70.16%   70.16%           
=======================================
  Files          59       59           
  Lines        8330     8330           
  Branches     8330     8330           
=======================================
  Hits         5845     5845           
  Misses       2012     2012           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/maintainance/remove_instances_of_trivial_entry_point/pt_2 branch 3 times, most recently from 3888b0b to 1262105 Compare March 2, 2024 09:01
@ArniStarkware ArniStarkware changed the base branch from arni/maintainance/remove_instances_of_trivial_entry_point/pt_2 to main March 2, 2024 09:06
@ArniStarkware ArniStarkware dismissed dorimedini-starkware’s stale review March 2, 2024 09:06

The base branch was changed.

@ArniStarkware ArniStarkware force-pushed the arni/maintainance/remove_create_account_tx_test_state branch from e2b0591 to de11260 Compare March 2, 2024 09:08
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware merged commit 74bc747 into main Mar 2, 2024
9 checks passed
@ArniStarkware ArniStarkware deleted the arni/maintainance/remove_create_account_tx_test_state branch March 2, 2024 09:23
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
…namespace (starkware-libs#1697)

* refactor(katana): change stored compiled class (starkware-libs#1559)

Both `blockifier` and `starknet_in_rust` use their own proprietary contract class types. So need to have a type where the types from those two crates can be derived from.

* refactor(katana-primitives): move class related types to a separate module (starkware-libs#1560)

* Katana executor traits (starkware-libs#1561)

* feat(katana-executor): add `blockifier` executor implementations (starkware-libs#1562)

implement the executor traits introduced in starkware-libs#1561 based on `blockifier`

* Refactor Katana to using the new executor traits (starkware-libs#1563)

integrate the new executor traits introduced in starkware-libs#1561 to katana

* feat(katana-executor): add starknet_in_rust executor (starkware-libs#1564)

* doc(katana-executor): add README

* test(katana-executor): add test for transaction simulation (starkware-libs#1593)

* test(katana-executor): refactor simulate tests (starkware-libs#1606)

refactor tests

* refactor(katana): decouple `katana-primitives` from any executor impls (starkware-libs#1637)

* test(katana-executor): improve tests and add test for state (starkware-libs#1649)

- add tests for each executor's CachedState
- improve test in executor.rs
- fix sir not enough gas error
- fix test in simulate.rs

* feat(saya): load data from Katana to run `SNOS` (starkware-libs#1535)

* chore: bump dependencies

* fix: update cairo-lang

* fix: add missing run_profiler

* fix: fmt

* update cairo-vm rev

* wip

* wip

* fmt

* fix: ensure semantics analyzer plugin is registered

* chore(katana): make ethers non optional since U256 is used outside messaging

* fix: run CAIRO_FIX_TESTS

* fix(dojo-core): remove compiler warnings

* git: add sozo generated bindings to gitignore

* fix: fix class hash

* fix: class hash generated code

* fix(dojo-core): fix tests and compilation warnings

* chore: integrate snos on cairo2.5

* chore: update Cargo.lock

* wip: work on integration of katana types

* wip: fetch strategy

* fix

* feat: add parsing of state diff for genesis block

* wip

* wip

* fix: rework provider for saya and RPC implem

* wip

* wip: snos types

* wip txs

* wip: fix snos parsing need to complete inputs

* chore: switch back to git snos

* chore: bump blockifier to use Serde on TransactionExecutionInfo

* feat: add saya RPC namespace

* feat: add transaction execution info to in memory db

* fix: remove unused code covered by other test

* fix: add logic for small requests to get transactions executions info

* fix: fetch transactions executions info instead of running blockifier

* fix: fmt and clippy

* docs: fix unused type

* fix: add tests for new transactions execution retrieval

* fix: add correct test to check no pending support

* fix: restore unchanged file

* fix: rename new provider trait to TransactionTraceProvider

* refactor(katana): change stored compiled class (starkware-libs#1559)

Both `blockifier` and `starknet_in_rust` use their own proprietary contract class types. So need to have a type where the types from those two crates can be derived from.

* refactor(katana-primitives): move class related types to a separate module (starkware-libs#1560)

* Katana executor traits (starkware-libs#1561)

* feat(katana-executor): add `blockifier` executor implementations (starkware-libs#1562)

implement the executor traits introduced in starkware-libs#1561 based on `blockifier`

* Refactor Katana to using the new executor traits (starkware-libs#1563)

integrate the new executor traits introduced in starkware-libs#1561 to katana

* feat(katana-executor): add starknet_in_rust executor (starkware-libs#1564)

* doc(katana-executor): add README

* test(katana-executor): add test for transaction simulation (starkware-libs#1593)

* test(katana-executor): refactor simulate tests (starkware-libs#1606)

refactor tests

* adjust new types for Katana blockchain and SNOS

* fix: clippy

* refactor(katana): change stored compiled class (starkware-libs#1559)

Both `blockifier` and `starknet_in_rust` use their own proprietary contract class types. So need to have a type where the types from those two crates can be derived from.

* refactor(katana-primitives): move class related types to a separate module (starkware-libs#1560)

* Katana executor traits (starkware-libs#1561)

* feat(katana-executor): add `blockifier` executor implementations (starkware-libs#1562)

implement the executor traits introduced in starkware-libs#1561 based on `blockifier`

* Refactor Katana to using the new executor traits (starkware-libs#1563)

integrate the new executor traits introduced in starkware-libs#1561 to katana

* feat(katana-executor): add starknet_in_rust executor (starkware-libs#1564)

* doc(katana-executor): add README

* test(katana-executor): add test for transaction simulation (starkware-libs#1593)

* test(katana-executor): refactor simulate tests (starkware-libs#1606)

refactor tests

* feat: add new primitive for trace and blockifier conversions

* feat: add TransactionExecutionInfo convert from blockifier

* feat: add executor trait method to retrieve the execution info

* fix: ensure tx execution info is passed in block producer

* chore: restore dependency on blockifier as we use TxExecInfo primitive

* refactor(katana): decouple `katana-primitives` from any executor impls (starkware-libs#1637)

* fix: clippy / fmt

* merge

* fix: clippy

---------

Co-authored-by: Kariy <ammr.arf@gmail.com>
Co-authored-by: Ammar Arif <evergreenkary@gmail.com>

* feat(katana-primitives): add fee info type

* Refactor executor output

* fix(katana): add missing contract address in `CallInfo`

* Remove `native` feature for now

* Limit nextest build jobs

* refactor(katana-executor): add logs for transaction events and resources

* fix(katana-executor): return reverted tx as error in estimate fee

---------

Co-authored-by: glihm <dev@glihm.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants