This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
fix(fee): count events of inner calls in get_tx_events_gas_cost #1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avi-starkware
requested review from
Yoni-Starkware,
giladchase and
barak-b-starkware
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-v0.13.1 #1744 +/- ##
================================================
+ Coverage 70.93% 70.94% +0.01%
================================================
Files 59 59
Lines 8076 8079 +3
Branches 8076 8079 +3
================================================
+ Hits 5729 5732 +3
Misses 1937 1937
Partials 410 410 ☔ View full report in Codecov by Sentry. |
Yoni-Starkware
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @barak-b-starkware and @giladchase)
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
…#1744) fix starkware-libs#1724 updated the test to make sure the gas prices doesn't get modified with the cli value in the [`update_block_env`](https://github.com/dojoengine/dojo/blob/ad58e43df7d162736fced6b071d59732183e77fb/crates/katana/core/src/backend/mod.rs#L182) method. now actual tx execution would result in a similar fee value that you get when doing fee estimation
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
…arkware-libs#1745) ref starkware-libs#1744 to limit and simplify how gas prices can be set in katana. currently there are two ways to do this: 1. using the `--*-gas-price` cli arg 2. set in the genesis config this change only allow the gas price to be set using one way or the other and not through a combination of both (eg pass a genesis config but set gas prices in cli) which makes it counterintuitive imo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is