Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore: sort versioned constants #2046

Open
wants to merge 1 commit into
base: main-v0.13.2
Choose a base branch
from

Conversation

dan-starkware
Copy link
Contributor

@dan-starkware dan-starkware commented Jul 7, 2024

This change is Reviewable

@dan-starkware dan-starkware changed the title Dan/sort versioned constants chore: sort versioned constants Jul 7, 2024
@dan-starkware dan-starkware changed the base branch from main to main-v0.12.3 July 7, 2024 11:45
@dan-starkware dan-starkware changed the base branch from main-v0.12.3 to main-v0.13.2 July 7, 2024 11:46
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)

a discussion (no related file):
approved wrong Pr


Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

approved wrong Pr

close this?


Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants