Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Improve diagnostics for wrong component embeddable name #6221

Closed
barak-b-starkware opened this issue Aug 18, 2024 · 1 comment · Fixed by #6226
Closed

dev: Improve diagnostics for wrong component embeddable name #6221

barak-b-starkware opened this issue Aug 18, 2024 · 1 comment · Fixed by #6226
Labels
enhancement New feature or request

Comments

@barak-b-starkware
Copy link

Within a starknet contract piece of code, if I use a component as follows:

#[abi(embed_v0)]
impl InternalName = SomeComponent::EmbeddableAsName<ContractState>;

and the EmbeddableAsName is wrong, I get and error: Trait not found. it appears at the top of the contract where #[starknet::contract] is placed.
IMO, It should imply which trait is not found or at least point to the component that caused the error.

@barak-b-starkware barak-b-starkware added the enhancement New feature or request label Aug 18, 2024
@orizi
Copy link
Collaborator

orizi commented Aug 18, 2024

Is this the only diagnostic you get?

@orizi orizi linked a pull request Aug 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants