Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better mapping for contract type-aliases. #6226

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 18, 2024

Copy link
Collaborator

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Collaborator

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi force-pushed the pr/orizi/updates/e1b0c9fb branch from 51d56e4 to 834791b Compare August 19, 2024 14:55
@orizi orizi force-pushed the pr/orizi/updates/9e8383ea branch from 405e9dc to 09ddce6 Compare August 19, 2024 14:55
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @mkaput)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from pr/orizi/updates/9e8383ea to main August 20, 2024 03:43
@orizi orizi force-pushed the pr/orizi/updates/e1b0c9fb branch from 834791b to 16f42c6 Compare August 20, 2024 03:43
@orizi orizi enabled auto-merge August 20, 2024 03:43
@orizi orizi added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit d69bf30 Aug 20, 2024
87 checks passed
@piotmag769 piotmag769 removed their request for review August 20, 2024 12:51
@orizi orizi deleted the pr/orizi/updates/e1b0c9fb branch August 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: Improve diagnostics for wrong component embeddable name
3 participants