-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made inline macros pluginable. #3873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)
a discussion (no related file):
How should we approach the selector!
macro with this change? Will we have StarkNetInlinePlugin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)
crates/cairo-lang-semantic/src/expr/compute.rs
line 280 at r1 (raw file):
let macro_name = syntax.path(syntax_db).as_syntax_node().get_text(syntax_db).trim().to_string(); let Some(macro_plugin) = ctx.db.inline_macro_plugins().into_iter().find(|plugin| plugin.name() == macro_name)
Can this be a map from name? it will be more efficinet than linear search.
58d819e
to
5058616
Compare
7441aba
to
86bbe83
Compare
5058616
to
f995f5b
Compare
19def5e
to
9d11bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 11 files reviewed, 1 unresolved discussion (waiting on @mkaput and @spapinistarkware)
a discussion (no related file):
Previously, mkaput (Marek Kaput) wrote…
How should we approach the
selector!
macro with this change? Will we haveStarkNetInlinePlugin
?
yes.
9d11bef
to
fffae8d
Compare
commit-id:3784e194
fffae8d
to
44ff562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 10 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput)
This change is