Added selector inline macro for starknet.

[orizi]

Stack:

• Made Destruct implementation do a single deconstruct. #3948
• Added derive for Hash. #3936
• Added derive for default. #3935
• Made the basic derive handle based, instead of get_impl. #3934
• Split derive plugin into files. #3933
• Improved array! macro diagnostics. #3922
• Improved consteval_int diagnostics. #3921
• Renamed and moved Patch to DiagnosticsMapper. #3920
• Extended origin for patches. #3919
• Added selector inline macro for starknet. #3912 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[mkaput]

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-compiler/src/db.rs line 103 at r1 (raw file):

    pub fn with_inline_macro_plugin(
        &mut self,
        name: impl Into<String>,

why not just &str ? Less stuff to monomorphize for Rust compiler

Suggestion:

&str

[orizi]

Reviewable status: 14 of 18 files reviewed, 1 unresolved discussion (waiting on @mkaput and @spapinistarkware)

---

crates/cairo-lang-compiler/src/db.rs line 103 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

why not just &str ? Less stuff to monomorphize for Rust compiler

Done.

[mkaput]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-starknet/src/inline_macros/selector.rs line 9 at r2 (raw file):

/// Macro for expanding a selector to a string literal.
#[derive(Debug)]

May I ask you to add this impl? I am relying on having T: Default bounds in Scarb code: https://github.com/software-mansion/scarb/blob/bf927194941f6c0ce62677e7e2ef4f9122489ff6/scarb/src/compiler/plugin/builtin.rs#L24

Suggestion:

#[derive(Debug, Default)]

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput and @spapinistarkware)

---

crates/cairo-lang-starknet/src/inline_macros/selector.rs line 9 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

May I ask you to add this impl? I am relying on having T: Default bounds in Scarb code: https://github.com/software-mansion/scarb/blob/bf927194941f6c0ce62677e7e2ef4f9122489ff6/scarb/src/compiler/plugin/builtin.rs#L24

if at some point we'd have plugins that requires params - how would you support it?
or all params for such plugins would ahve to be salsa db inputs? (as they are for cfg for example)

[mkaput]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-starknet/src/inline_macros/selector.rs line 9 at r2 (raw file):

Previously, orizi wrote…

if at some point we'd have plugins that requires params - how would you support it?
or all params for such plugins would ahve to be salsa db inputs? (as they are for cfg for example)

Pull stuff from salsa. I can't see any other way to pass params to plugins when they'll be written as packages, especially because I believe the constructor will have to be representable as extern "C".

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput and @spapinistarkware)

---

crates/cairo-lang-starknet/src/inline_macros/selector.rs line 9 at r2 (raw file):

Previously, mkaput (Marek Kaput) wrote…

Pull stuff from salsa. I can't see any other way to pass params to plugins when they'll be written as packages, especially because I believe the constructor will have to be representable as extern "C".

Done.

[mkaput]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[orizi]

Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[mkaput]

Reviewed 8 of 8 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[gilbens-starkware]

Reviewed 6 of 18 files at r1, 2 of 4 files at r2, 1 of 1 files at r3, 4 of 8 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

---

crates/cairo-lang-starknet/src/inline_macros/selector.rs line 28 at r5 (raw file):

            let diagnostics = vec![PluginDiagnostic {
                stable_ptr: syntax.stable_ptr().untyped(),
                message: "selector macro must have a single argument".to_string(),

Suggestion:

Selector

[gilbens-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @spapinistarkware)

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[gilbens-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)