Changed diagnostics to have full file paths

[yuvalsw]

This change is 

[orizi]

Reviewed 6 of 11 files at r1, all commit messages.
Reviewable status: 6 of 11 files reviewed, 2 unresolved discussions (waiting on @yuvalsw)

---

crates/cairo-lang-filesystem/src/ids.rs line 115 at r1 (raw file):

    fn full_path(&self, db: &dyn FilesGroup) -> String {
        if let Some(parent) = self.parent {
            format!("{}[{}]", parent.full_path(db), self.name)

can you explain this path?

Code quote:

"{}[{}]

---

crates/cairo-lang-plugins/src/test.rs line 153 at r1 (raw file):

}

fn test_general_plugin(

is this related?

[yuvalsw]

Reviewable status: 6 of 12 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-filesystem/src/ids.rs line 115 at r1 (raw file):

Previously, orizi wrote…

can you explain this path?

I didn't want to have a.cairo/virtual_file/virtual_file2.
I hoped you'd suggest something else for the syntax of a virtual file path.

---

crates/cairo-lang-plugins/src/test.rs line 153 at r1 (raw file):

Previously, orizi wrote…

is this related?

Yes, I wanted to have a diagnostic with a path to a double-indirected file. See
"error: Double indirection diagnostic
--> test_src/lib.cairo[virt1][virt2]:1:1
"
in file "general".

[orizi]

Reviewed 2 of 11 files at r1, 2 of 2 files at r2.
Reviewable status: 9 of 12 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

---

crates/cairo-lang-filesystem/src/ids.rs line 115 at r1 (raw file):

Previously, yuvalsw wrote…

I didn't want to have a.cairo/virtual_file/virtual_file2.
I hoped you'd suggest something else for the syntax of a virtual file path.

add a todo to choose a more readable path.
and add to discussions.

[orizi]

Reviewed 1 of 11 files at r1.
Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @yuvalsw)

[yuvalsw]

Reviewable status: 10 of 12 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-filesystem/src/ids.rs line 115 at r1 (raw file):

Previously, orizi wrote…

add a todo to choose a more readable path.
and add to discussions.

Done.

[orizi]

Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

[orizi]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)

[orizi]

Reviewed 4 of 4 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yuvalsw)