-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS: Clean up hover definition logic #5780
Conversation
838e531
to
ed41a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
crates/cairo-lang-defs/src/db.rs
line 113 at r2 (raw file):
// TODO(mkaput): Add tests. // TODO(mkaput): Support #[doc] attribute. This will be a bigger chunk of work because it would // be the best to convert all /// comments to #[doc] attrs before processing items by plugins,
not sure if these should be equivalent exactly - but indeed should be easily accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
crates/cairo-lang-defs/src/db.rs
line 113 at r2 (raw file):
Previously, orizi wrote…
not sure if these should be equivalent exactly - but indeed should be easily accessible.
In rust they are all are concatenated. You can mix ///
, #[doc]
, //!
and #![doc]
on the same item and all are concatenated in source code order. Concatenation happens before macros, so macro_rules!
are only seeing one #[doc]
attribute when matching for example.
ed41a02
to
eda9018
Compare
84a3798
to
1dc5e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
1. Reorganized logic scaffolding to resemble RA's code. 2. Added `Markdown` utility and added unit tests. 3. Moved `///` stripping into Salsa as this looks like a more proper place. 4. Converted everything to use `MarkupContent`, as using `MarkedString` is deprecated in protocol. 5. Added highlights for hover targets, now identifiers get nice background in VSCode when hovering over them. commit-id:56d17f49
eda9018
to
827cfaa
Compare
Markdown
utility and added unit tests.///
stripping into Salsa as this looks like a more proper place.
MarkupContent
,as using
MarkedString
is deprecated in protocol.now identifiers get nice background in VSCode when hovering over them.
Stack:
get_item_definition
toget_item_signature
#5783lang::db
module #5782This change is