-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS: Add a command to inspect analyzed crates #5987
Conversation
58b1606
to
276d1d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 16 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Draggu and @mkaput)
crates/cairo-lang-language-server/src/lang/inspect/crates.rs
line 27 at r2 (raw file):
} fn inspect_crate(cr: Crate) -> String {
doc.
crates/cairo-lang-language-server/src/lang/inspect/crates.rs
line 39 at r2 (raw file):
} fn indent(text: String) -> String {
there's an existing crate for this function:
indent::indent_by
.
crates/cairo-lang-language-server/tests/e2e/support/normalize.rs
line 12 at r2 (raw file):
fn inner(fixture: &Fixture, data: String) -> String { normalize_well_known_paths(fixture, normalize_paths(data)) }
why use an inner function?
Code quote:
fn inner(fixture: &Fixture, data: String) -> String {
normalize_well_known_paths(fixture, normalize_paths(data))
}
e160b04
to
c6b9a5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 18 files reviewed, 3 unresolved discussions (waiting on @Draggu and @orizi)
crates/cairo-lang-language-server/src/lang/inspect/crates.rs
line 27 at r2 (raw file):
Previously, orizi wrote…
doc.
Done.
crates/cairo-lang-language-server/src/lang/inspect/crates.rs
line 39 at r2 (raw file):
Previously, orizi wrote…
there's an existing crate for this function:
indent::indent_by
.
Done.
crates/cairo-lang-language-server/tests/e2e/support/normalize.rs
line 12 at r2 (raw file):
Previously, orizi wrote…
why use an inner function?
Ah, I applied the following pattern habitually, yet it's non-effective here. Done.
c6b9a5d
to
f84d5db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Draggu)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 16 files at r1, 3 of 6 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mkaput)
f84d5db
to
31675c7
Compare
commit-id:26737288
31675c7
to
a351465
Compare
This change is