Make trait completion add a visible use path. #6091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orizi
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mkaput and @piotmag769)
piotmag769
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
gilbens-starkware
force-pushed
the
spr/dev-v2.7.0/41236fd0
branch
from
a4b9408 to
8112d4d
Compare
gilbens-starkware
force-pushed
the
spr/dev-v2.7.0/849ce212
branch
from
e43df81 to
783eaac
Compare
commit-id:849ce212
gilbens-starkware
changed the base branch from
spr/dev-v2.7.0/41236fd0
to
dev-v2.7.0
gilbens-starkware
force-pushed
the
spr/dev-v2.7.0/849ce212
branch
from
783eaac to
78ac3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is