-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corelib: circuit related utils improvements #6482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @feltroidprime)
corelib/src/circuit.cairo
line 278 at r1 (raw file):
match self { AddInputResult::Done(data) => data, AddInputResult::More(_) => panic_with_felt252('Not all inputs have been filled'),
Suggestion:
),
AddInputResult::Done(_) => core::panic_with_felt252('All inputs have been filled'),
}
}
// Inlining to make sure possibly huge `C` won't be in a user function name.
#[inline]
fn done(self: AddInputResult<C>) -> CircuitData<C> {
match self {
AddInputResult::Done(data) => data,
AddInputResult::More(_) => core::panic_with_felt252('Not all inputs have been filled'),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @feltroidprime)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @feltroidprime)
a discussion (no related file):
please run fixer for all tests.
CAIRO_FIX_TESTS=1 cargo t --profile=ci-dev
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @feltroidprime)
a discussion (no related file):
@ilyalesokhin-starkware for second eye.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @feltroidprime)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @feltroidprime)
Thank you! |
circuit.cairo
One
for u384panic_with_felt252
instead ofpanic!
macro (this significantly reduces bytecode) innext
anddone
metaprogramming.cairo
This change is