LS: Add completions of struct members

[integraledelebesgue]

Stack:

• LS: Limit module import completion to visible members #6566
• LS: Add "fill struct fields" code action #6565
• LS: Add completions of struct members #6567 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[piotmag769]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @integraledelebesgue, @mkaput, and @orizi)

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 25 at r1 (raw file):

            x: 0x0,
            y: 0x0,
            z: 0x0

I guess missing here?

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 40 at r1 (raw file):

            x: 0x0,
            <caret>
            ..s

To make sure it doesn't work in the second case

Suggestion:

            <caret>
            <caret>..s

[mkaput]

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Arcticae, @Draggu, @integraledelebesgue, and @orizi)

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 47 at r1 (raw file):

mod happy_cases {
    use super::some_module::Struct;
    

please trim whitespace in empty lines

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 62 at r1 (raw file):

            x: 0x0,
            <caret>
        }

consider putting all of these in single line so that source line contexts will make sense

Suggestion:

        let a = Struct { <caret> };

        let b = Struct { y: 0x0, <caret> };

        let c = Struct { y: 0x0, x: 0x0, <caret> }

[integraledelebesgue]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Arcticae, @Draggu, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 25 at r1 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

I guess missing here?

This struct is instantiated only to be used below in a "tail": ..s

[piotmag769]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @integraledelebesgue, and @orizi)

[integraledelebesgue]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 62 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

consider putting all of these in single line so that source line contexts will make sense

Done.

[integraledelebesgue]

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @Arcticae, @Draggu, @mkaput, @orizi, and @piotmag769)

---

crates/cairo-lang-language-server/tests/test_data/completions/structs.txt line 47 at r1 (raw file):

Previously, mkaput (Marek Kaput) wrote…

please trim whitespace in empty lines

Done.

[mkaput]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)

[piotmag769]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae, @Draggu, and @orizi)

[orizi]

Reviewed 1 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae and @Draggu)

[Draggu]

Reviewed 1 of 4 files at r1, 1 of 1 files at r2, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[mkaput]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[mkaput]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[piotmag769]

Reviewed 1 of 2 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae and @integraledelebesgue)

---

crates/cairo-lang-language-server/src/ide/completion/completions.rs line 363 at r5 (raw file):

    let struct_members =
        concrete_struct_members(db, constructor_semantic_expr.concrete_struct_id).ok()?;

This is a query, use it as one

Suggestion:

db.concrete_struct_members(constructor_semantic_expr.concrete_struct_id)

[piotmag769]

Reviewed 1 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Arcticae and @integraledelebesgue)

[integraledelebesgue]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @Arcticae, @mkaput, and @piotmag769)

---

crates/cairo-lang-language-server/src/ide/completion/completions.rs line 363 at r5 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

This is a query, use it as one

Done

[piotmag769]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[mkaput]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)

[mkaput]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Arcticae)