Core Lib Documentation: Clone module

[TAdev0]

No description provided.

[reviewable-StarkWare]

This change is 

[enitrat]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @TAdev0)

---

corelib/src/clone.cairo line 38 at r1 (raw file):

//! ```

/// `Clone` trait defines the interface for cloning values.

I would add more details than just this

/// A common trait for the ability to explicitly duplicate an object.
///
/// Differs from `Copy` in that `Copy` is implicit and inexpensive, while
/// `Clone` is always explicit and may or may not be expensive.
///
/// Since `Clone` is more general than `Copy`, you can automatically make anything
/// `Copy` be `Clone` as well.
///
/// ## Derivable
///
/// This trait can be used with `#[derive]` if all fields are `Clone`. The `derive`d
/// implementation of `Clone` calls `clone` on each field.
///

Question to @orizi: what's the compiler behavior when deriving a trait on a generic struct?

Would it be true to say that "For a generic struct, #[derive] implements Clone conditionally by adding bound Clone on generic parameters." (as in Rust) ?

---

corelib/src/clone.cairo line 40 at r1 (raw file):

/// `Clone` trait defines the interface for cloning values.
pub trait Clone<T> {
    /// Takes a snapshot of a copyable value and returns a clone of that value.

T is not "copyable" here (if you mean a trait bound on +Copy)

Suggestion:

/// Returns a copy of the value.