Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treating all gas-vars as provided 0 if gas is disabled. #6688

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Nov 18, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/ignore-gas-when-wallet-disabled branch from 7e3d6ea to 40b5049 Compare November 18, 2024 15:20
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi force-pushed the orizi/ignore-gas-when-wallet-disabled branch from 40b5049 to cd23a0a Compare November 19, 2024 12:08
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 1d9c664 Nov 21, 2024
48 checks passed
@orizi orizi deleted the orizi/ignore-gas-when-wallet-disabled branch November 28, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants