update error message for missing '0x' prefix #6869
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @chen-liang-CN)
crates/cairo-lang-utils/src/bigint.rs line 34 at r1 (raw file):
Some(num_no_prefix) => BigUint::from_str_radix(num_no_prefix, 16) .map_err(|error| serde::de::Error::custom(format!("{error}"))), None => Err(serde::de::Error::custom(format!("{s} does not start with '0x', which is missing."))),
revert this part.
and run ./scripts/rust_fmt.sh.
Suggestion:
ith `0x`,
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-utils/src/bigint.rs line 34 at r1 (raw file):
Previously, orizi wrote…
revert this part.
and run./scripts/rust_fmt.sh.
Done.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @chen-liang-CN)
Summary
The error message read a bit strange, so I updated it to make it more explicit.