Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding @T impls near T definition. #7024

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 8, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 28 of 29 files at r1, all commit messages.
Reviewable status: 28 of 29 files reviewed, all discussions resolved

@orizi orizi enabled auto-merge January 8, 2025 15:35
@orizi orizi force-pushed the orizi/find-snapshot-in-lookup-ctx branch from b0b026e to ad44ae8 Compare January 8, 2025 15:36
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 29 files at r1.
Reviewable status: 28 of 29 files reviewed, all discussions resolved

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 28 of 29 files reviewed, all discussions resolved

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 29 files at r1.
Reviewable status: 28 of 29 files reviewed, all discussions resolved

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 29 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 65023ee Jan 8, 2025
48 checks passed
@orizi orizi deleted the orizi/find-snapshot-in-lookup-ctx branch January 15, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants