Add TypedSyntaxNode::cast and Terminal::cast_token methods #7044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
orizi
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @wawel37)
mkaput
changed the title
orizi
pushed a commit
that referenced
this pull request
Jan 15, 2025
orizi
pushed a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern of checking for node kind and them calling panicking
from_syntax_nodeis pretty common and these little methods could simplify a lot of code. I took the name from Rust Analyzer's codebase.