Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Ok,Err,Some,None from prelude. #7157

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 25, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/use-enum-variant-prelude branch from a3255a8 to 09a19c2 Compare January 26, 2025 04:55
Copy link
Collaborator

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 125 of 125 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @mkaput)

@orizi orizi force-pushed the orizi/use-enum-variant-prelude branch 2 times, most recently from b70a588 to 63d5522 Compare January 26, 2025 07:59
@orizi orizi force-pushed the orizi/use-enum-variant-prelude branch from 63d5522 to 5a7b709 Compare January 26, 2025 08:07
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 43 of 125 files at r1, 4 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@orizi orizi added this pull request to the merge queue Jan 26, 2025
Copy link
Collaborator

@dean-starkware dean-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

Merged via the queue into main with commit fdb292e Jan 26, 2025
48 checks passed
@orizi orizi deleted the orizi/use-enum-variant-prelude branch January 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants