-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(corelib): RangeInclusiveTrait #7158
feat(corelib): RangeInclusiveTrait #7158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)
a discussion (no related file):
@gilbens-starkware for 2nd eye.
corelib/src/ops/range.cairo
line 206 at r1 (raw file):
#[inline] fn is_empty(self: @RangeInclusive<T>) -> bool { !(self.start <= self.end)
Suggestion:
self.start > self.end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/ops/range.cairo
line 206 at r1 (raw file):
#[inline] fn is_empty(self: @RangeInclusive<T>) -> bool { !(self.start <= self.end)
Done.
73d6f66
to
b19e6fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)
No description provided.