Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(corelib): RangeInclusiveTrait #7158

Merged

Conversation

MagisterDaIlis
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MagisterDaIlis)


a discussion (no related file):
@gilbens-starkware for 2nd eye.


corelib/src/ops/range.cairo line 206 at r1 (raw file):

    #[inline]
    fn is_empty(self: @RangeInclusive<T>) -> bool {
        !(self.start <= self.end)

Suggestion:

        self.start > self.end

Copy link
Contributor Author

@MagisterDaIlis MagisterDaIlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


corelib/src/ops/range.cairo line 206 at r1 (raw file):

    #[inline]
    fn is_empty(self: @RangeInclusive<T>) -> bool {
        !(self.start <= self.end)

Done.

@MagisterDaIlis MagisterDaIlis force-pushed the feat/range-inclusive-contains branch from 73d6f66 to b19e6fe Compare January 26, 2025 09:19
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)

Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MagisterDaIlis)

@orizi orizi added this pull request to the merge queue Jan 29, 2025
Merged via the queue into starkware-libs:main with commit 71d6052 Jan 29, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants