Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay failure on unknown type for tuple style types. #7160

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 26, 2025

Partially solving issue #7155.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi force-pushed the orizi/unknown-tuple-ty-conform branch from 6c2082c to 18cfd6c Compare January 26, 2025 14:14
@orizi orizi force-pushed the orizi/unknown-tuple-ty-conform branch from 18cfd6c to 034a274 Compare January 26, 2025 14:32
Copy link
Contributor

@gilbens-starkware gilbens-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit e2ab0a5 Jan 26, 2025
48 checks passed
@orizi orizi deleted the orizi/unknown-tuple-ty-conform branch January 29, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants