Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify compilation for other platfroms #11

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
cmake_minimum_required (VERSION 3.5)
if (NOT DEFINED CMAKE_CXX_COMPILER)
set(CMAKE_CXX_COMPILER /usr/bin/clang++-6.0)
set(CMAKE_CXX_COMPILER /usr/bin/clang++)
endif()

project(StarkwareCryptoLib VERSION 0.1.0 LANGUAGES CXX)

set(CMAKE_CXX_STANDARD 17)

include(FetchContent)
FetchContent_Declare(
googletest
URL https://github.com/google/googletest/archive/609281088cfefc76f9d0ce82e1ff6c30cc3591e5.zip
)
# For Windows: Prevent overriding the parent project's compiler/linker settings
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
FetchContent_MakeAvailable(googletest)

include(CTest)
# Basic setup for gtest
find_package(GTest REQUIRED)
include_directories(${GTEST_INCLUDE_DIRS})
enable_testing()
include_directories("${CMAKE_SOURCE_DIR}/src")

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ This repo requires the installation of the Golang compiler on the system in orde
presubmit script and the provided Go FFI and test. To install Go under Ubuntu, run the following:

``sudo apt install golang-go``

For 32-bit builds to work, boost library is required.
6 changes: 3 additions & 3 deletions src/starkware/algebra/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
add_library(algebra prime_field_element.cc)

add_executable(big_int_test big_int_test.cc)
target_link_libraries(big_int_test gtest gtest_main pthread)
target_link_libraries(big_int_test gtest gtest_main gmock pthread)
add_test(big_int_test big_int_test)

add_executable(prime_field_element_test prime_field_element_test.cc)
target_link_libraries(prime_field_element_test algebra gtest gtest_main pthread)
add_test(prime_field_element_test prime_field_element_test)

add_executable(fraction_field_element_test fraction_field_element_test.cc)
target_link_libraries(fraction_field_element_test algebra gtest gtest_main pthread)
target_link_libraries(fraction_field_element_test algebra gtest gtest_main gmock pthread)
add_test(fraction_field_element_test fraction_field_element_test)

add_executable(elliptic_curve_test elliptic_curve_test.cc)
target_link_libraries(elliptic_curve_test algebra gtest gtest_main pthread)
target_link_libraries(elliptic_curve_test algebra gtest gtest_main gmock pthread)
add_test(elliptic_curve_test elliptic_curve_test)
8 changes: 8 additions & 0 deletions src/starkware/algebra/big_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@
#include "starkware/utils/error_handling.h"
#include "starkware/utils/prng.h"

/*
Support for 32-bit builds, where __uint128_t isn't defined.
*/
#ifndef __SIZEOF_INT128__
#include <boost/multiprecision/cpp_int.hpp>
typedef boost::multiprecision::uint128_t __uint128_t;
#endif

namespace starkware {

static constexpr inline __uint128_t Umul128(uint64_t x, uint64_t y) {
Expand Down
2 changes: 1 addition & 1 deletion src/starkware/crypto/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ add_library(crypto elliptic_curve_constants.cc pedersen_hash.cc ecdsa.cc)
target_link_libraries(crypto algebra)

add_executable(elliptic_curve_constants_test elliptic_curve_constants_test.cc)
target_link_libraries(elliptic_curve_constants_test gtest crypto gtest_main pthread)
target_link_libraries(elliptic_curve_constants_test gtest crypto gtest_main gmock pthread)
add_test(elliptic_curve_constants_test elliptic_curve_constants_test)

add_executable(pedersen_hash_test pedersen_hash_test.cc)
Expand Down
8 changes: 4 additions & 4 deletions src/starkware/crypto/ffi/js/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
add_custom_command(
OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so
OUTPUT ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto
COMMAND
${CMAKE_COMMAND} -E copy
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.so
${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so
${CMAKE_CURRENT_BINARY_DIR}/../libcrypto_c_exports.*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To copy both .so and .dylib (mac) shared libs

${CMAKE_CURRENT_SOURCE_DIR}
DEPENDS crypto_c_exports
)

add_custom_target(js_test ALL
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto_c_exports.so
DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/libcrypto
)

add_test(
Expand Down
2 changes: 1 addition & 1 deletion src/starkware/crypto/ffi/js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"license": "Apache-2.0",
"dependencies": {
"bigint-buffer": "^1.1.5",
"bn": "^1.0.5",
"bn.js": "^5.2.0",
"ffi-napi": "^3.1.0"
},
"devDependencies": {
Expand Down
112 changes: 112 additions & 0 deletions src/starkware/crypto/ffi/portable_endian.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
#ifndef STARKWARE_CRYPTO_FFI_PORTABLE_ENDIAN_H_
#define STARKWARE_CRYPTO_FFI_PORTABLE_ENDIAN_H_

#if (defined(_WIN16) || defined(_WIN32) || defined(_WIN64)) && !defined(__WINDOWS__)

# define __WINDOWS__

#endif

#if defined(__linux__) || defined(__CYGWIN__)

# include <endian.h>

#elif defined(__APPLE__)

# include <libkern/OSByteOrder.h>

# define htobe16(x) OSSwapHostToBigInt16(x)
# define htole16(x) OSSwapHostToLittleInt16(x)
# define be16toh(x) OSSwapBigToHostInt16(x)
# define le16toh(x) OSSwapLittleToHostInt16(x)

# define htobe32(x) OSSwapHostToBigInt32(x)
# define htole32(x) OSSwapHostToLittleInt32(x)
# define be32toh(x) OSSwapBigToHostInt32(x)
# define le32toh(x) OSSwapLittleToHostInt32(x)

# define htobe64(x) OSSwapHostToBigInt64(x)
# define htole64(x) OSSwapHostToLittleInt64(x)
# define be64toh(x) OSSwapBigToHostInt64(x)
# define le64toh(x) OSSwapLittleToHostInt64(x)

# define __BYTE_ORDER BYTE_ORDER
# define __BIG_ENDIAN BIG_ENDIAN
# define __LITTLE_ENDIAN LITTLE_ENDIAN
# define __PDP_ENDIAN PDP_ENDIAN

#elif defined(__OpenBSD__)

# include <sys/endian.h>

#elif defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)

# include <sys/endian.h>

# define be16toh(x) betoh16(x)
# define le16toh(x) letoh16(x)

# define be32toh(x) betoh32(x)
# define le32toh(x) letoh32(x)

# define be64toh(x) betoh64(x)
# define le64toh(x) letoh64(x)

#elif defined(__WINDOWS__)

# include <winsock2.h>
# include <sys/param.h>

# if BYTE_ORDER == LITTLE_ENDIAN

# define htobe16(x) htons(x)
# define htole16(x) (x)
# define be16toh(x) ntohs(x)
# define le16toh(x) (x)

# define htobe32(x) htonl(x)
# define htole32(x) (x)
# define be32toh(x) ntohl(x)
# define le32toh(x) (x)

# define htobe64(x) htonll(x)
# define htole64(x) (x)
# define be64toh(x) ntohll(x)
# define le64toh(x) (x)

# elif BYTE_ORDER == BIG_ENDIAN

/* that would be xbox 360 */
# define htobe16(x) (x)
# define htole16(x) __builtin_bswap16(x)
# define be16toh(x) (x)
# define le16toh(x) __builtin_bswap16(x)

# define htobe32(x) (x)
# define htole32(x) __builtin_bswap32(x)
# define be32toh(x) (x)
# define le32toh(x) __builtin_bswap32(x)

# define htobe64(x) (x)
# define htole64(x) __builtin_bswap64(x)
# define be64toh(x) (x)
# define le64toh(x) __builtin_bswap64(x)

# else

# error byte order not supported

# endif

# define __BYTE_ORDER BYTE_ORDER
# define __BIG_ENDIAN BIG_ENDIAN
# define __LITTLE_ENDIAN LITTLE_ENDIAN
# define __PDP_ENDIAN PDP_ENDIAN

#else

# error platform not supported

#endif

#endif // STARKWARE_CRYPTO_FFI_PORTABLE_ENDIAN_H_
2 changes: 1 addition & 1 deletion src/starkware/crypto/ffi/utils.cc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#include <endian.h>
#include <algorithm>
#include <cstring>

#include "starkware/crypto/ffi/utils.h"
#include "starkware/crypto/ffi/portable_endian.h"

namespace starkware {

Expand Down
2 changes: 1 addition & 1 deletion src/starkware/starkex/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ add_library(starkex order.cc)
target_link_libraries(starkex crypto)

add_executable(order_test order_test.cc)
target_link_libraries(order_test starkex gtest gtest_main pthread)
target_link_libraries(order_test starkex gtest gtest_main gmock pthread)
add_test(order_test order_test)
4 changes: 2 additions & 2 deletions src/starkware/utils/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
add_executable(math_test math_test.cc)
target_link_libraries(math_test gtest gtest_main pthread)
target_link_libraries(math_test gtest gtest_main gmock pthread)
add_test(math_test math_test)

add_executable(prng_test prng_test.cc)
target_link_libraries(prng_test gtest gtest_main pthread)
target_link_libraries(prng_test gtest gtest_main gmock pthread)
add_test(prng_test prng_test)