Fixed return type of Verify function in ffi/ecdsa.cc #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ffi/ecdsa.h
the interface of Verify method is as follows:but in
ffi/ecdsa.cc
it had a bool type.The problem it caused:
I compiled crypto-cpp for Release (with -O3 flag), for ios and macos targets. On x86 macos target, calling Verify function would return very big numbers instead of 0 or 1.