Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove &self arg from AccountTransaction::handle_fee #218

Conversation

tdelabro
Copy link

@tdelabro tdelabro commented Jul 31, 2024

fixes: starkware-libs/blockifier#1770

This change is Reviewable

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @tdelabro)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tdelabro)

@tdelabro tdelabro force-pushed the remove-self-from-account-tx-handle-fee branch from 6a74ce0 to c9cf640 Compare September 2, 2024 09:03
@tdelabro
Copy link
Author

tdelabro commented Sep 2, 2024

@meship-starkware the CI was failing, I rebased on main's latest commit. Let's see if it fixes it. Can you run the CI again please?

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (d1aa365) to head (c9cf640).
Report is 306 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   76.62%   71.51%   -5.11%     
==========================================
  Files         351       85     -266     
  Lines       37223    10859   -26364     
  Branches    37223    10859   -26364     
==========================================
- Hits        28522     7766   -20756     
+ Misses       6388     2695    -3693     
+ Partials     2313      398    -1915     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccountTransaction::handle_fee should not take &self as arg
2 participants