Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_batcher): delete obsolete todo #2389

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.11%. Comparing base (e3165c4) to head (30eb306).
Report is 660 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2389       +/-   ##
==========================================
- Coverage   40.10%   5.11%   -34.99%     
==========================================
  Files          26     145      +119     
  Lines        1895   17058    +15163     
  Branches     1895   17058    +15163     
==========================================
+ Hits          760     873      +113     
- Misses       1100   16128    +15028     
- Partials       35      57       +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yael-Starkware Yael-Starkware marked this pull request as ready for review December 2, 2024 11:02
@Yael-Starkware Yael-Starkware requested a review from alonh5 December 2, 2024 15:39
Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Yael-Starkware Yael-Starkware merged commit fe2a865 into main Dec 3, 2024
10 checks passed
@Yael-Starkware Yael-Starkware deleted the yael/delete_todo branch December 3, 2024 06:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants