-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): proposer rotates across validators #2405
feat(consensus): proposer rotates across validators #2405
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
===========================================
- Coverage 40.10% 17.97% -22.14%
===========================================
Files 26 119 +93
Lines 1895 13888 +11993
Branches 1895 13888 +11993
===========================================
+ Hits 760 2496 +1736
- Misses 1100 11121 +10021
- Partials 35 271 +236 ☔ View full report in Codecov by Sentry. |
5743df8
to
906d4b6
Compare
906d4b6
to
195d20e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 214 at r1 (raw file):
fn proposer(&self, height: BlockNumber, round: Round) -> ValidatorId { let height: usize = height.0.try_into().expect("Cannot convert to usize");
Consider using recommended message style
Code quote:
Cannot convert to usize
No description provided.