Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): proposer rotates across validators #2405

Conversation

matan-starkware
Copy link
Contributor

No description provided.

@matan-starkware matan-starkware marked this pull request as ready for review December 2, 2024 12:26
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 17.97%. Comparing base (e3165c4) to head (195d20e).
Report is 664 commits behind head on main.

Files with missing lines Patch % Lines
...us_orchestrator/src/sequencer_consensus_context.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2405       +/-   ##
===========================================
- Coverage   40.10%   17.97%   -22.14%     
===========================================
  Files          26      119       +93     
  Lines        1895    13888    +11993     
  Branches     1895    13888    +11993     
===========================================
+ Hits          760     2496     +1736     
- Misses       1100    11121    +10021     
- Partials       35      271      +236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus/milestone2/sequencer_context_proposer_selection branch from 5743df8 to 906d4b6 Compare December 2, 2024 12:38
@matan-starkware matan-starkware force-pushed the matan/consensus/milestone2/sequencer_context_proposer_selection branch from 906d4b6 to 195d20e Compare December 2, 2024 12:45
Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)


crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 214 at r1 (raw file):

    fn proposer(&self, height: BlockNumber, round: Round) -> ValidatorId {
        let height: usize = height.0.try_into().expect("Cannot convert to usize");

Consider using recommended message style

Code quote:

Cannot convert to usize

Copy link
Contributor Author

matan-starkware commented Dec 3, 2024

Merge activity

  • Dec 3, 4:31 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 3, 4:32 AM EST: A user merged this pull request with Graphite.

@matan-starkware matan-starkware merged commit 4b0d3c5 into main Dec 3, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants