Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): sequencer context broadcasts votes #2422

Merged

Conversation

matan-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review December 3, 2024 09:54
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Dec 3, 2024

Artifacts upload workflows:

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.49%. Comparing base (e3165c4) to head (0aa727f).
Report is 683 commits behind head on main.

Files with missing lines Patch % Lines
...us_orchestrator/src/sequencer_consensus_context.rs 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2422       +/-   ##
===========================================
+ Coverage   40.10%   77.49%   +37.38%     
===========================================
  Files          26      387      +361     
  Lines        1895    41109    +39214     
  Branches     1895    41109    +39214     
===========================================
+ Hits          760    31856    +31096     
- Misses       1100     7001     +5901     
- Partials       35     2252     +2217     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@asmaastarkware asmaastarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @yair-starkware)

@dan-starkware
Copy link
Collaborator

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 92 at r1 (raw file):

    pub fn new(
        batcher: Arc<dyn BatcherClient>,
        _proposal_streaming_client: BroadcastTopicClient<ProposalPart>,

How is this still the case?

Code quote:

_proposal_streaming_client

Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware and @yair-starkware)

Copy link
Contributor Author

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @yair-starkware)


crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 92 at r1 (raw file):

Previously, dan-starkware wrote…

How is this still the case?

It's a naming issue, guy is clenaing up

Copy link
Contributor Author

matan-starkware commented Dec 4, 2024

Merge activity

  • Dec 4, 2:32 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 2:32 AM EST: A user merged this pull request with Graphite.

@matan-starkware matan-starkware merged commit ed273b2 into main Dec 4, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants