-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus): sequencer context broadcasts votes #2422
feat(consensus): sequencer context broadcasts votes #2422
Conversation
Artifacts upload workflows: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
===========================================
+ Coverage 40.10% 77.49% +37.38%
===========================================
Files 26 387 +361
Lines 1895 41109 +39214
Branches 1895 41109 +39214
===========================================
+ Hits 760 31856 +31096
- Misses 1100 7001 +5901
- Partials 35 2252 +2217 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware and @yair-starkware)
How is this still the case? Code quote: _proposal_streaming_client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware and @yair-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @yair-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 92 at r1 (raw file):
Previously, dan-starkware wrote…
How is this still the case?
It's a naming issue, guy is clenaing up
No description provided.