-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add native dependencies to the CI (dynamic docker) #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 25 files at r1.
Reviewable status: 1 of 26 files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @meship-starkware, and @varex83)
.github/actions/setup-native-deps/action.yml
line 25 at r1 (raw file):
sudo apt-get install -y zstd sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools sudo apt-get install -y libgmp3-dev
script it and use it in the docker build and in the action
Code quote:
- name: Add llvm deb repository
uses: myci-actions/add-deb-repo@11
with:
repo: deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main
repo-name: llvm-repo
keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
- name: Install LLVM and gmplib
shell: bash
run: |
sudo apt-get update && sudo apt-get upgrade -y
sudo apt-get install -y zstd
sudo apt-get install llvm-18 llvm-18-dev llvm-18-runtime clang-18 clang-tools-18 lld-18 libpolly-18-dev libmlir-18-dev mlir-18-tools
sudo apt-get install -y libgmp3-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r2, all commit messages.
Reviewable status: 3 of 26 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 26 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)
Benchmark movements: |
Benchmark movements: full_committer_flow performance improved 😺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 25 files at r1, 2 of 4 files at r2, 2 of 2 files at r18, 1 of 1 files at r19, 1 of 3 files at r20, 1 of 2 files at r21, 6 of 6 files at r22, 1 of 1 files at r23, 1 of 1 files at r24, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @meship-starkware, and @varex83)
crates/blockifier/feature_contracts/cairo1/compiled/account_faulty.casm.json
line 3 at r24 (raw file):
{ "prime": "0x800000000000011000000000000000000000000000000000000000000000001", "compiler_version": "2.8.2",
Did you recompile those contracts with 2.8.2 version?
Code quote:
"compiler_version": "2.8.2",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @meship-starkware, and @noaov1)
crates/blockifier/feature_contracts/cairo1/compiled/account_faulty.casm.json
line 3 at r24 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Did you recompile those contracts with 2.8.2 version?
yes, since the feature contracts test was arguing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)
Solution given in #726 |
This change is