feat: integrated with get-starknet-wallet #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
requested changes
Apr 24, 2022
Comment on lines
41
to
42
| logoPath.startsWith('data:image') ? ( | ||
| <img alt={''} height={logoSize} src={logoPath} width={logoSize} /> |
There was a problem hiding this comment.
wallet window objects provide their own icon/logo data; here we show it via <img> element
There was a problem hiding this comment.
OK, can you please move this logic to a renderWalletLogo function so the JSX will be more readable?
dan-ziv
reviewed
Apr 24, 2022
Co-authored-by: Dan Ziv <danz@starkware.co>
dan-ziv
approved these changes
Apr 25, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Apr 25, 2022
## [1.3.0-dev.1](v1.2.1-dev.5...v1.3.0-dev.1) (2022-04-25) ### 🧩 Features * integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a))
|
🎉 This PR is included in version 1.3.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
May 2, 2022
## [1.2.0](v1.1.0...v1.2.0) (2022-05-02) ### 💉 Improvements * move to hooks useConstants, useEnvs, useTranslation ([#159](#159)) ([b77ba11](b77ba11)) * useTracking ([#160](#160)) ([a8cad80](a8cad80)) * useTranslation hooks ([#162](#162)) ([92e0927](92e0927)) ### 🧩 Features * integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a)) * terms of use ([#141](#141)) ([8d9fe79](8d9fe79)) * validate starknet wallet chain ID ([#168](#168)) ([2551a7f](2551a7f)) ### 🔧 Fixes * accept button stayed disabled when browser zoom is different from 100% ([#158](#158)) ([1e4afac](1e4afac)) * add ETH mainnet addresses ([#167](#167)) ([56fa74b](56fa74b)) * app crashed when trying to connect while ArgentX wasn't installed ([55e25f7](55e25f7)) * bad overflow in modal for content with very long strings ([#161](#161)) ([36a1c6f](36a1c6f)) * calc L2 tx hash in the background ([#169](#169)) ([80d23d2](80d23d2)) * canceled transfers shown in transfer log ([#166](#166)) ([69324e8](69324e8)) * **deps:** bump gsw version ([6c01ae5](6c01ae5)) * **Faq:** question 8 ([#157](#157)) ([51da4aa](51da4aa)) * handle display of exponential balances ([44c675b](44c675b)) * isInstalled() check for gsw ([#165](#165)) ([1881192](1881192)) * unsupported chain id does not showing ([#151](#151)) ([afa5294](afa5294)) * use getStarknet() provider on starknet contracts ([1d6b023](1d6b023)) * use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee)) * **utils:** get url params returns undefined ([cde6401](cde6401))
dan-ziv
pushed a commit
that referenced
this pull request
May 2, 2022
## [1.3.0](v1.2.0...v1.3.0) (2022-05-02) ### 💉 Improvements * move to hooks useConstants, useEnvs, useTranslation ([#159](#159)) ([b77ba11](b77ba11)) * useTracking ([#160](#160)) ([a8cad80](a8cad80)) * useTranslation hooks ([#162](#162)) ([92e0927](92e0927)) ### 🧩 Features * integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a)) * validate starknet wallet chain ID ([#168](#168)) ([2551a7f](2551a7f)) ### 🔧 Fixes * add ETH mainnet addresses ([#167](#167)) ([56fa74b](56fa74b)) * bad overflow in modal for content with very long strings ([#161](#161)) ([36a1c6f](36a1c6f)) * calc L2 tx hash in the background ([#169](#169)) ([80d23d2](80d23d2)) * canceled transfers shown in transfer log ([#166](#166)) ([69324e8](69324e8)) * **deps:** bump gsw version ([6c01ae5](6c01ae5)) * handle display of exponential balances ([44c675b](44c675b)) * isInstalled() check for gsw ([#165](#165)) ([1881192](1881192)) * use getStarknet() provider on starknet contracts ([1d6b023](1d6b023)) * use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee)) * **utils:** get url params returns undefined ([cde6401](cde6401))
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Enhancement:
I've created a new library that is compatible with the current
getStarknet()API but is able to support more wallets on StarkNet.This PR integrates starkgate-frontend with that lib - adding multiple StarkNet wallets support in starkgate-frontend - without changing anything but one import line, and a few icons/texts to make the connect-L2-wallet step 100% wallet-agnostic.
Checklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is