Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsupported chain id does not showing #151

Merged
merged 8 commits into from
Apr 13, 2022
Merged

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Apr 12, 2022

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv merged commit 017ce0a into dev Apr 13, 2022
@dan-ziv dan-ziv deleted the fix/unsupported-chain-id branch April 13, 2022 09:55
dan-ziv pushed a commit that referenced this pull request Apr 13, 2022
 ## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13)

### 🔧 Fixes

* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 13, 2022

🎉 This PR is included in version 1.2.0-dev.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 13, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Apr 13, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13)

### 🔧 Fixes

* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13)

### 🔧 Fixes

* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-14)

### 🔧 Fixes

* accept button stays disabled when zoom is different from 100% ([#155](#155)) ([de7f6d0](de7f6d0))
* app crashed when trying to connect while ArgentX wasn't installed ([e8c4e63](e8c4e63))
* **Faq:** update question 8  ([#149](#149)) ([84acc20](84acc20))
* unsupported chain id does not showing  ([#151](#151)) ([83a6f87](83a6f87))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-14)

### 🔧 Fixes

* accept button stays disabled when zoom is different from 100% ([#155](#155)) ([de7f6d0](de7f6d0))
* app crashed when trying to connect while ArgentX wasn't installed ([e8c4e63](e8c4e63))
* **Faq:** update question 8  ([#149](#149)) ([84acc20](84acc20))
* unsupported chain id does not showing  ([#151](#151)) ([83a6f87](83a6f87))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-14)

### 🔧 Fixes

* accept button stays disabled when zoom is different from 100% ([#155](#155)) ([de7f6d0](de7f6d0))
* app crashed when trying to connect while ArgentX wasn't installed ([e8c4e63](e8c4e63))
* **Faq:** update question 8  ([#149](#149)) ([84acc20](84acc20))
* unsupported chain id does not showing  ([#151](#151)) ([83a6f87](83a6f87))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13)

### 🔧 Fixes

* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.4](v1.2.0-dev.3...v1.2.0-dev.4) (2022-04-13)

### 🔧 Fixes

* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-14)

### 🔧 Fixes

* accept button stays disabled when zoom is different from 100% ([#156](#156)) ([a745e6c](a745e6c))
* app crashed when trying to connect while ArgentX wasn't installed ([fac0208](fac0208))
* **Faq:** update question 8  ([#149](#149)) ([a5a66c1](a5a66c1))
* unsupported chain id does not showing  ([#151](#151)) ([922e6c9](922e6c9))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.3](v1.2.0-dev.2...v1.2.0-dev.3) (2022-04-14)

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([55e25f7](55e25f7))
* unsupported chain id does not showing  ([#151](#151)) ([afa5294](afa5294))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-14)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* accept button stayed disabled when browser zoom is different from 100% ([#158](#158)) ([1e4afac](1e4afac))
* app crashed when trying to connect while ArgentX wasn't installed ([55e25f7](55e25f7))
* **Faq:** question 8 ([#157](#157)) ([51da4aa](51da4aa))
* unsupported chain id does not showing  ([#151](#151)) ([afa5294](afa5294))
dan-ziv pushed a commit that referenced this pull request May 2, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-05-02)

### 💉 Improvements

* move to hooks useConstants, useEnvs, useTranslation ([#159](#159)) ([b77ba11](b77ba11))
* useTracking ([#160](#160)) ([a8cad80](a8cad80))
* useTranslation hooks ([#162](#162)) ([92e0927](92e0927))

### 🧩 Features

* integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a))
* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))
* validate starknet wallet chain ID ([#168](#168)) ([2551a7f](2551a7f))

### 🔧 Fixes

* accept button stayed disabled when browser zoom is different from 100% ([#158](#158)) ([1e4afac](1e4afac))
* add ETH mainnet addresses ([#167](#167)) ([56fa74b](56fa74b))
* app crashed when trying to connect while ArgentX wasn't installed ([55e25f7](55e25f7))
* bad overflow in modal for content with very long strings ([#161](#161)) ([36a1c6f](36a1c6f))
* calc L2 tx hash in the background ([#169](#169)) ([80d23d2](80d23d2))
* canceled transfers shown in transfer log ([#166](#166)) ([69324e8](69324e8))
* **deps:** bump gsw version ([6c01ae5](6c01ae5))
* **Faq:** question 8 ([#157](#157)) ([51da4aa](51da4aa))
* handle display of exponential balances ([44c675b](44c675b))
* isInstalled() check for gsw ([#165](#165)) ([1881192](1881192))
* unsupported chain id does not showing  ([#151](#151)) ([afa5294](afa5294))
* use getStarknet() provider on starknet contracts ([1d6b023](1d6b023))
* use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee))
* **utils:** get url params returns undefined ([cde6401](cde6401))
@dan-ziv dan-ziv restored the fix/unsupported-chain-id branch September 6, 2022 11:17
@dan-ziv dan-ziv deleted the fix/unsupported-chain-id branch September 6, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant