Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Terms): add notes #144

Merged
merged 4 commits into from
Apr 11, 2022
Merged

fix(Terms): add notes #144

merged 4 commits into from
Apr 11, 2022

Conversation

CarmitKl
Copy link

@CarmitKl CarmitKl commented Apr 11, 2022

Add terms-notes text to the Terms tab.

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@CarmitKl CarmitKl requested a review from dan-ziv April 11, 2022 11:20
@CarmitKl CarmitKl added the ready for review Pull request is ready to be reviewed label Apr 11, 2022
@dan-ziv dan-ziv changed the title fix: add terms-notes text to the Terms tab fix: add terms notes Apr 11, 2022
@dan-ziv dan-ziv changed the title fix: add terms notes fix(Terms): add notes Apr 11, 2022
@dan-ziv dan-ziv merged commit b007f3e into dev Apr 11, 2022
@dan-ziv dan-ziv deleted the fix/addTermsNotesText branch April 11, 2022 19:34
dan-ziv pushed a commit that referenced this pull request Apr 11, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-11)

### 🔧 Fixes

* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Apr 11, 2022

🎉 This PR is included in version 1.2.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 13, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
@dan-ziv
Copy link
Collaborator

dan-ziv commented Apr 13, 2022

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-11)

### 🔧 Fixes

* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0-dev.2](v1.2.0-dev.1...v1.2.0-dev.2) (2022-04-11)

### 🔧 Fixes

* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
dan-ziv pushed a commit that referenced this pull request Apr 14, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-04-13)

### 🧩 Features

* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))

### 🔧 Fixes

* app crashed when trying to connect while ArgentX wasn't installed ([74e6861](74e6861))
* **Faq:** update question 8  ([#149](#149)) ([67f50f7](67f50f7))
* **Terms:** add notes ([#144](#144)) ([b007f3e](b007f3e))
* unsupported chain id does not showing  ([#151](#151)) ([017ce0a](017ce0a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready to be reviewed released on @dev released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants