Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use wallet provider for all provider calls #170

Merged
merged 1 commit into from
May 1, 2022

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented May 1, 2022

Description of the Changes

defaultProvider by default is working against Goerli testnet.
For mainnet envs we should work with the wallet provider (i.e. getStarknet().provider).

Checklist

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

@dan-ziv dan-ziv merged commit 7d75dc8 into hotfix-v1.2.0 May 1, 2022
@dan-ziv dan-ziv deleted the fix/use-wallet-provider branch May 1, 2022 08:26
dan-ziv pushed a commit that referenced this pull request May 1, 2022
 ## [1.3.0-dev.9](v1.3.0-dev.8...v1.3.0-dev.9) (2022-05-01)

### 🔧 Fixes

* use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee))
dan-ziv pushed a commit that referenced this pull request May 2, 2022
 ## [1.2.0](v1.1.0...v1.2.0) (2022-05-02)

### 💉 Improvements

* move to hooks useConstants, useEnvs, useTranslation ([#159](#159)) ([b77ba11](b77ba11))
* useTracking ([#160](#160)) ([a8cad80](a8cad80))
* useTranslation hooks ([#162](#162)) ([92e0927](92e0927))

### 🧩 Features

* integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a))
* terms of use ([#141](#141)) ([8d9fe79](8d9fe79))
* validate starknet wallet chain ID ([#168](#168)) ([2551a7f](2551a7f))

### 🔧 Fixes

* accept button stayed disabled when browser zoom is different from 100% ([#158](#158)) ([1e4afac](1e4afac))
* add ETH mainnet addresses ([#167](#167)) ([56fa74b](56fa74b))
* app crashed when trying to connect while ArgentX wasn't installed ([55e25f7](55e25f7))
* bad overflow in modal for content with very long strings ([#161](#161)) ([36a1c6f](36a1c6f))
* calc L2 tx hash in the background ([#169](#169)) ([80d23d2](80d23d2))
* canceled transfers shown in transfer log ([#166](#166)) ([69324e8](69324e8))
* **deps:** bump gsw version ([6c01ae5](6c01ae5))
* **Faq:** question 8 ([#157](#157)) ([51da4aa](51da4aa))
* handle display of exponential balances ([44c675b](44c675b))
* isInstalled() check for gsw ([#165](#165)) ([1881192](1881192))
* unsupported chain id does not showing  ([#151](#151)) ([afa5294](afa5294))
* use getStarknet() provider on starknet contracts ([1d6b023](1d6b023))
* use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee))
* **utils:** get url params returns undefined ([cde6401](cde6401))
dan-ziv pushed a commit that referenced this pull request May 2, 2022
 ## [1.3.0](v1.2.0...v1.3.0) (2022-05-02)

### 💉 Improvements

* move to hooks useConstants, useEnvs, useTranslation ([#159](#159)) ([b77ba11](b77ba11))
* useTracking ([#160](#160)) ([a8cad80](a8cad80))
* useTranslation hooks ([#162](#162)) ([92e0927](92e0927))

### 🧩 Features

* integrated with get-starknet-wallet ([#163](#163)) ([e0f996a](e0f996a))
* validate starknet wallet chain ID ([#168](#168)) ([2551a7f](2551a7f))

### 🔧 Fixes

* add ETH mainnet addresses ([#167](#167)) ([56fa74b](56fa74b))
* bad overflow in modal for content with very long strings ([#161](#161)) ([36a1c6f](36a1c6f))
* calc L2 tx hash in the background ([#169](#169)) ([80d23d2](80d23d2))
* canceled transfers shown in transfer log ([#166](#166)) ([69324e8](69324e8))
* **deps:** bump gsw version ([6c01ae5](6c01ae5))
* handle display of exponential balances ([44c675b](44c675b))
* isInstalled() check for gsw ([#165](#165)) ([1881192](1881192))
* use getStarknet() provider on starknet contracts ([1d6b023](1d6b023))
* use wallet provider for all provider calls ([#170](#170)) ([646feee](646feee))
* **utils:** get url params returns undefined ([cde6401](cde6401))
@dan-ziv dan-ziv restored the fix/use-wallet-provider branch September 6, 2022 11:18
@dan-ziv dan-ziv deleted the fix/use-wallet-provider branch September 6, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant