fix: redux error on switching menu "non-serializable value was detected" #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsferMenu' function
CarmitKl
changed the title
CarmitKl
added
ready for review
dan-ziv
approved these changes
Mar 22, 2022
dan-ziv
pushed a commit
that referenced
this pull request
Mar 29, 2022
## [0.1.0-dev.1](v0.0.1...v0.1.0-dev.1) (2022-03-29) ### 🧩 Features * handle browser support ([#96](#96)) ([56d920d](56d920d)) * remove redux and use providers ([#98](#98)) ([ed38ae4](ed38ae4)) * **toasts:** add link to transfer log ([#79](#79)) ([b743b85](b743b85)) * use blockNumber=pending for balanceOf calls ([#58](#58)) ([9a84b05](9a84b05)) ### 💉 Improvements * continuous integration ([#99](#99)) ([adc15b5](adc15b5)) * utils ([#82](#82)) ([c38e56e](c38e56e)) ### 🔧 Fixes * add missing env poll block number interval ([d364cb4](d364cb4)) * ci ([2a92c4a](2a92c4a)) * ci ([541e34b](541e34b)) * **getTransactionHash:** add fee and version to calculation ([#90](#90)) ([938ffe0](938ffe0)) * redux error on switching menu "non-serializable value was detected" ([#89](#89)) ([9dc4972](9dc4972)) * remove pending transfer toast ([#92](#92)) ([20f51f3](20f51f3)) * update ETH token addresses and add SLF token ([#84](#84)) ([2c5a9df](2c5a9df))
|
🎉 This PR is included in version 0.1.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
Apr 4, 2022
## [1.0.0-dev.1](v0.0.1...v1.0.0-dev.1) (2022-04-04) ### ⚠ BREAKING CHANGES * alpha version (#126) ### 💉 Improvements * utils ([#82](#82)) ([c38e56e](c38e56e)) ### 🔧 Fixes * add missing env poll block number interval ([d364cb4](d364cb4)) * **getTransactionHash:** add fee and version to calculation ([#90](#90)) ([938ffe0](938ffe0)) * redux error on switching menu "non-serializable value was detected" ([#89](#89)) ([9dc4972](9dc4972)) * remove pending transfer toast ([#92](#92)) ([20f51f3](20f51f3)) * update ETH token addresses and add SLF token ([#84](#84)) ([2c5a9df](2c5a9df)) ### 🧩 Features * alpha version ([#126](#126)) ([5b15ca0](5b15ca0)) * handle browser support ([#96](#96)) ([56d920d](56d920d)) * remove redux and use providers ([#98](#98)) ([ed38ae4](ed38ae4)) * **toasts:** add link to transfer log ([#79](#79)) ([b743b85](b743b85)) * use blockNumber=pending for balanceOf calls ([#58](#58)) ([9a84b05](9a84b05))
|
🎉 This PR is included in version 1.0.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
Apr 4, 2022
## [1.0.0](v0.0.1...v1.0.0) (2022-04-04) ### ⚠ BREAKING CHANGES * alpha version (#126) ### 💉 Improvements * utils ([#82](#82)) ([c38e56e](c38e56e)) ### 🧩 Features * alpha version ([#126](#126)) ([5b15ca0](5b15ca0)) * handle browser support ([#96](#96)) ([56d920d](56d920d)) * remove redux and use providers ([#98](#98)) ([ed38ae4](ed38ae4)) * **toasts:** add link to transfer log ([#79](#79)) ([b743b85](b743b85)) * use blockNumber=pending for balanceOf calls ([#58](#58)) ([9a84b05](9a84b05)) ### 🔧 Fixes * add missing env poll block number interval ([d364cb4](d364cb4)) * empty callback in promise .then ([#127](#127)) ([9d13c3b](9d13c3b)) * **getTransactionHash:** add fee and version to calculation ([#90](#90)) ([938ffe0](938ffe0)) * redux error on switching menu "non-serializable value was detected" ([#89](#89)) ([9dc4972](9dc4972)) * remove pending transfer toast ([#92](#92)) ([20f51f3](20f51f3)) * update ETH token addresses and add SLF token ([#84](#84)) ([2c5a9df](2c5a9df))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling the function 'showTransferMenu' from clicking on the 'Account.js' + 'SelectToken.js' > backButton was accidentally passing the click-event.
This PR fixes that. Now it's clear that all calls to the function 'showTransferMenu' don't pass the browser event.
This change is