Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(winget): Add support for winget package manager #4042

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

Letsch22
Copy link
Contributor

@Letsch22 Letsch22 commented Jun 4, 2022

Description

Adds a release step for publishing Starship to the winget package manager for Windows

Motivation and Context

Thought I would kick this off now that #4031 is complete. Still requires an initial wingetcreate new once #4029 releases so that the wingetcreate tool can download and analyze the MSI installers and generate a manifest that this pipeline step can update thereafter. After that, testing this pipeline step will become possible.

Closes #1295

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna
Copy link
Member

davidkna commented Jun 5, 2022

Still requires an initial wingetcreate new once #4029 releases so that the wingetcreate tool can download and analyze the MSI installers and generate a manifest that this pipeline step can update thereafter.

Does this go into the main starship repo, or does this just need to be added to the winget-pkgs repo?

@Letsch22
Copy link
Contributor Author

Letsch22 commented Jun 5, 2022

Does this go into the main starship repo, or does this just need to be added to the winget-pkgs repo?

@davidkna I think the generated manifest could optionally be checked in to the starship repo but as you said the main thing is to have it added to https://github.com/microsoft/winget-pkgs. The wingetcreate new command will automatically create a PR against that repo to add the manifest if you provide a GH personal access token with the -t argument.

Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add winget to the installation method list.

.github/workflows/release.yml Show resolved Hide resolved
@Letsch22
Copy link
Contributor Author

@davidkna Added installation documentation in my latest commit

README.md Outdated
Comment on lines 254 to 255
Install the latest version for your system with the MSI-installers from the [releases section](https://github.com/starship/starship/releases/latest).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this line, I'd still like to mention that starship can be installed without any extra tools.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added back these lines in my latest commit

@davidkna davidkna merged commit ef52f9e into starship:master Jun 23, 2022
@davidkna
Copy link
Member

Thanks for the contribution @Letsch22.

Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
* Add winget update release step

* Hardcode MSI URLs for wingetcreate

* Fix variable expansion reference

* Add winget install documentation

* Revert removing MSI installer documentation

Co-authored-by: Daniel Letscher <Letsch22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in winget Package Manager
2 participants