-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(winget): Add support for winget package manager #4042
Conversation
Does this go into the main starship repo, or does this just need to be added to the winget-pkgs repo? |
@davidkna I think the generated manifest could optionally be checked in to the starship repo but as you said the main thing is to have it added to https://github.com/microsoft/winget-pkgs. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add winget
to the installation method list.
@davidkna Added installation documentation in my latest commit |
README.md
Outdated
Install the latest version for your system with the MSI-installers from the [releases section](https://github.com/starship/starship/releases/latest). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this line, I'd still like to mention that starship can be installed without any extra tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added back these lines in my latest commit
Thanks for the contribution @Letsch22. |
* Add winget update release step * Hardcode MSI URLs for wingetcreate * Fix variable expansion reference * Add winget install documentation * Revert removing MSI installer documentation Co-authored-by: Daniel Letscher <Letsch22@users.noreply.github.com>
Description
Adds a release step for publishing Starship to the winget package manager for Windows
Motivation and Context
Thought I would kick this off now that #4031 is complete. Still requires an initial
wingetcreate new
once #4029 releases so that thewingetcreate
tool can download and analyze the MSI installers and generate a manifest that this pipeline step can update thereafter. After that, testing this pipeline step will become possible.Closes #1295
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: