Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine crn #322

Closed
wants to merge 14 commits into from
Closed

Combine crn #322

wants to merge 14 commits into from

Conversation

cliffckerr
Copy link
Contributor

@cliffckerr cliffckerr commented Feb 27, 2024 •
edited
Loading

Merge of #307 and #313

NB: changed base to main since now more closely related to that than #307

@cliffckerr cliffckerr changed the base branch from main to fix_crn February 27, 2024 17:54
@cliffckerr cliffckerr changed the base branch from fix_crn to main February 28, 2024 06:23
@cliffckerr cliffckerr mentioned this pull request Feb 28, 2024
Closed
@cliffckerr
Copy link
Contributor Author

Currently, this branch is slower than main with the new multi-RNG implementation. For main, benchmark_full.py is 4674 ± 32 ms, this branch is 6260 ± 29 ms. Would definitely need to fix that before merging this!

@cliffckerr cliffckerr mentioned this pull request Mar 18, 2024
Merged
@cliffckerr
Copy link
Contributor Author

Closed by #392

@cliffckerr cliffckerr closed this Mar 19, 2024
@cliffckerr cliffckerr deleted the combine-crn branch March 30, 2024 14:34
@cliffckerr cliffckerr restored the combine-crn branch March 30, 2024 14:34
@cliffckerr cliffckerr deleted the combine-crn branch March 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-klein daniel-klein Awaiting requested review from daniel-klein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Random numbers & distributions
Development

Successfully merging this pull request may close these issues.
1 participant
@cliffckerr