V0.5 fixes #527
Merged
V0.5 fixes #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
Closed
kaa2102
reviewed
May 28, 2024
There was a problem hiding this comment.
The move from 'delta' to 'constant' is just a lot more logical and clear to understand for users.
kaa2102
reviewed
May 28, 2024
tests/test_networks.py
Outdated
There was a problem hiding this comment.
Adding StaticNet to tests expands test coverage! DynamicNet is tested via MaternalNet and RandomNet. This leaves: NullNet and SexualNet as classes excluded from testing in 'network.py'. I will add a test for this for Issue #515.
kaa2102
approved these changes
May 28, 2024
robynstuart
approved these changes
May 28, 2024
| @@ -104,7 +104,7 @@ def check_requires(self, sim): | |||
| raise Exception(errormsg) | |||
| return | |||
|
|
|||
| def initialize(self, sim): | |||
| def init_pre(self, sim): | |||
There was a problem hiding this comment.
i reckon there should be a comment somewhere that attempts to clarify for users which things should go in init vs init_pre vs init_post. maybe in these docstrings?
starsim/distributions.py
Outdated
| @@ -587,7 +587,7 @@ def plot_hist(self, n=1000, bins=None, fig_kw=None, hist_kw=None): | |||
|
|
|||
| # Add common distributions so they can be imported directly; assigned to a variable since used in help messages | |||
| dist_list = ['random', 'uniform', 'normal', 'lognorm_ex', 'lognorm_im', 'expon', | |||
| 'poisson', 'weibull', 'delta', 'randint', 'bernoulli', 'choice'] | |||
| 'poisson', 'weibull', 'const', 'randint', 'bernoulli', 'choice'] | |||
There was a problem hiding this comment.
not constant? it's only 8 letters, shorter than the lognorm_** options! at least make an alias?
Updated Starsim README.rst for public GitHub and PyPI pages.
Update read me for pypi
…upport-all-or-nothing-vaccines Add option of sir_vaccine to be leaky or all_or_nothing
…ecome_pregnant Ensure unborn agents cannot become pregnant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various bugfixes; namely:
ss.deltatoss.const#490initialize()/init_vals()#506Checklist