Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arr API tweaks #544

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Arr API tweaks #544

merged 12 commits into from
Jun 11, 2024

Conversation

RomeshA
Copy link
Contributor

@RomeshA RomeshA commented Jun 10, 2024

Description

Minor changes to the Arr API. Main differences:

  • isnan returns a BoolArr facilitating operations like (self.cd4.isnan & self.infected).uids
  • Added operators to uids to facilitate set operations

Checklist

  • Code commented & docstrings added
  • New tests were needed and have been added
  • A new version number was needed & changelog has been updated
  • A new PyPI version needs to be released

@RomeshA RomeshA requested a review from cliffckerr June 10, 2024 04:03
@daniel-klein daniel-klein requested a review from robynstuart June 10, 2024 23:25
Copy link
Contributor

@cliffckerr cliffckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like how this simplifies the logic considerably, but there are no backwards-incompatible changes.

@cliffckerr cliffckerr merged commit f27ba84 into main Jun 11, 2024
3 checks passed
@cliffckerr cliffckerr deleted the arr-api-tweaks branch June 11, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants