Remove all ros::object slots in def-set-get-param-method #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all
ros::object
slots instead ofplist
and_connection-header
indef-set-get-param-method
, so that even if definition ofros::object
changes in the future this code remains functional.jsk-ros-pkg/jsk_roseus#606
Also changing to use
symbol-name
instead offormat
. Strings get to uppercase, but since they areread-string
ed afterwards should make no difference.>>Need testing<<
Btw some random notes:
I'm pretty sure that
string-left-trim
is not the right function here, specially ifrtc_name
may contain underscores.rtmros_common/hrpsys_ros_bridge/euslisp/rtm-ros-robot-interface.l
Lines 236 to 258 in 0ac8868
function "string-trim" behaves suspiciously euslisp/EusLisp#249
string trim is sometimes incorrect euslisp/EusLisp#336
(elt ":" 0)
=>#\: