Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing install rule for calibration pkg #397

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

130s
Copy link
Contributor

@130s 130s commented Oct 21, 2015

@130s
Copy link
Contributor Author

130s commented Oct 26, 2015

Please review @k-okada
Does this break anything?

@k-okada
Copy link
Member

k-okada commented Oct 27, 2015

if you assume users https://github.com/ros-drivers/openni_launch/blob/hydro-devel/launch/openni.launch
it will publishes tf and that will conflict ,
http://wiki.ros.org/rtmros_nextage/Tutorials/CalibrateKinect#Before_Calibration
is intend to "templary" fix urdf and revert after that, and start kinect with openni.launch that publishes tf, but if you include camera frame to urdf, be sure to run openni.launch without tf publishing, this behavior can reproduce with hrpsys-simulation and real kinect camera hardware, so you can try.

travis also reported error.

@130s 130s force-pushed the fix/installrule branch 3 times, most recently from ff31c60 to bf6a1dc Compare October 31, 2015 02:42
@130s
Copy link
Contributor Author

130s commented Oct 31, 2015

I see.
So I think I split this PR; I removed the commit for kinect link and will open a new PR for it.
Now this PR only contains a fix to the missing install rule.

@k-okada
Copy link
Member

k-okada commented Oct 31, 2015

If you want to calibrate Kinect, we have 3 strategy and super strongly start from 1st method, starting from step 3 too difficult for anyone;
1 manually change head-camera static tf and check if that is correct from Rviz
2 attach calibration board in the robot body and measure board-camera tf from CV tool and find head-camera tf
3 use http://wiki.ros.org/rtmros_nextage/Tutorials/CalibrateKinect#Before_Calibration

Please please please, start from 1st method;
Even so you have to find;

  • how to mannualy change static tf of head-camera
  • how to determine if that is correct on Rviz

@130s 130s changed the title Improvement for calibration with Kinect Add missing install rule for calibration pkg Oct 31, 2015
@130s
Copy link
Contributor Author

130s commented Nov 2, 2015

Now travis passed for hydro.
Adding Kinect to URDF is ticketed separately #405.

130s added a commit that referenced this pull request Nov 2, 2015
Add missing install rule for calibration pkg
@130s 130s merged commit 018e7e2 into start-jsk:hydro-devel Nov 2, 2015
@130s 130s deleted the fix/installrule branch November 2, 2015 06:52
130s added a commit that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants