Address feedback

startreedata · Oct 9, 2024 · 286c1cc · 286c1cc
1 parent 052793c
commit 286c1cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/thirdeye-server/src/main/java/ai/startree/thirdeye/resources/DataSourceResource.java b/thirdeye-server/src/main/java/ai/startree/thirdeye/resources/DataSourceResource.java
@@ -134,7 +134,6 @@ public Response onboardAll(
  }
 
  @POST
- @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
  @Path("recommend")
  @Timed(percentiles = {0.5, 0.75, 0.90, 0.95, 0.98, 0.99, 0.999})
  @Produces(MediaType.APPLICATION_JSON)

diff --git a/thirdeye-server/src/main/java/ai/startree/thirdeye/service/DataSourceService.java b/thirdeye-server/src/main/java/ai/startree/thirdeye/service/DataSourceService.java
@@ -33,6 +33,7 @@
 import ai.startree.thirdeye.spi.datalayer.bao.DataSourceManager;
 import ai.startree.thirdeye.spi.datalayer.bao.DatasetConfigManager;
 import ai.startree.thirdeye.spi.datalayer.dto.AbstractDTO;
+import ai.startree.thirdeye.spi.datalayer.dto.AuthorizationConfigurationDTO;
 import ai.startree.thirdeye.spi.datalayer.dto.DataSourceDTO;
 import ai.startree.thirdeye.spi.datalayer.dto.DatasetConfigDTO;
 import ai.startree.thirdeye.spi.datasource.ThirdEyeDataSource;
@@ -179,6 +180,13 @@ public boolean validate(final ThirdEyePrincipal principal, final long id) {
  }
 
  public DataSourceApi recommend(final ThirdEyePrincipal principal) {
+ final String namespace = authorizationManager.currentNamespace(principal);
+
+ // verify that user has read access to data sources in given namespace
+ DataSourceDTO sampleDataset = new DataSourceDTO();
+ sampleDataset.setAuth(new AuthorizationConfigurationDTO().setNamespace(namespace));
+ authorizationManager.ensureCanRead(principal, sampleDataset);
+
  return authorizationManager.generateDatasourceConnection(principal);
  }
 }