[server] Add recommend API to datasource resource #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyrilou242
requested changes
Oct 8, 2024
thirdeye-server/src/main/java/ai/startree/thirdeye/service/DataSourceService.java
Show resolved
Hide resolved
| @@ -133,6 +133,16 @@ public Response onboardAll( | |||
| return respondOk(onboarded); | |||
| } | |||
|
|
|||
| @POST | |||
| @Consumes(MediaType.APPLICATION_FORM_URLENCODED) | |||
anshul98ks123
force-pushed
the
TE-recommend-datasource-api
branch
from
19e8cb3
to
490e065
Compare
cyrilou242
reviewed
Oct 9, 2024
| final String namespace = authorizationManager.currentNamespace(principal); | ||
|
|
||
| // verify that user has read access to data sources in given namespace | ||
| DataSourceDTO sampleDataset = new DataSourceDTO(); |
anshul98ks123
changed the base branch from
master
to
TE-namespace-configuration
anshul98ks123
changed the base branch from
TE-namespace-configuration
to
master
anshul98ks123
force-pushed
the
TE-recommend-datasource-api
branch
from
c296190
to
507a606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Pinot connection
Description
Adding new API
api/data-sources/recommendIt will be used in datasource onboarding UI flow to generate recommended datasource connection config
(importantly for Shared SaaS setup)
Depends on #1584
Testing
UTs and
Sanity swagger test (should return 200 response with null body due to default implementation)