Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spi] Add default implementation of generateDatasourceConnection in ThirdEyeAuthorizer #1587

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

anshul98ks123
Copy link
Contributor

Issue(s)

Pinot connection

Description

Adding default implementation of generateDatasourceConnection method to avoid breaking change

Testing

Existing Tests and CI

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 9:53am

Copy link
Collaborator

@cyrilou242 cyrilou242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anshul98ks123 anshul98ks123 merged commit 4375970 into master Oct 9, 2024
12 checks passed
@anshul98ks123 anshul98ks123 deleted the TE-fix-interface branch October 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants