Add config option to require scene draft submissions (#789)

README.md

@@ -103,6 +103,7 @@ There are two ways to authenticate a user in Stash-box: a session or an API key.
 | `postgres.max_open_conns` | (0) | Maximum number of concurrent open connections to the database. |
 | `postgres.max_idle_conns` | (0) | Maximum number of concurrent idle database connections. |
 | `postgres.conn_max_lifetime` | (0) | Maximum lifetime in minutes before a connection is released. |
+| `require_scene_draft` | false | Whether to allow scene creation outside of draft submissions. |
 
 ## SSL (HTTPS)
 

frontend/src/graphql/queries/Config.gql

@@ -9,5 +9,6 @@ query Config {
     min_destructive_voting_period
     vote_cron_interval
     guidelines_url
+    require_scene_draft
   }
 }

frontend/src/graphql/types.ts

@@ -1582,6 +1582,7 @@ export type StashBoxConfig = {
   min_destructive_voting_period: Scalars["Int"]["output"];
   require_activation: Scalars["Boolean"]["output"];
   require_invite: Scalars["Boolean"]["output"];
+  require_scene_draft: Scalars["Boolean"]["output"];
   vote_application_threshold: Scalars["Int"]["output"];
   vote_cron_interval: Scalars["String"]["output"];
   vote_promotion_threshold?: Maybe<Scalars["Int"]["output"]>;
@@ -14131,6 +14132,7 @@ export type ConfigQuery = {
     min_destructive_voting_period: number;
     vote_cron_interval: string;
     guidelines_url: string;
+    require_scene_draft: boolean;
   };
 };
 
@@ -39759,6 +39761,10 @@ export const ConfigDocument = {
                   kind: "Field",
                   name: { kind: "Name", value: "guidelines_url" },
                 },
+                {
+                  kind: "Field",
+                  name: { kind: "Name", value: "require_scene_draft" },
+                },
               ],
             },
           },

frontend/src/pages/scenes/Scenes.tsx

@@ -2,7 +2,7 @@ import { FC, useContext } from "react";
 import { Button } from "react-bootstrap";
 import { Link } from "react-router-dom";
 
-import { CriterionModifier } from "src/graphql";
+import { CriterionModifier, useConfig } from "src/graphql";
 import { canEdit, createHref } from "src/utils";
 import AuthContext from "src/AuthContext";
 import { SceneList } from "src/components/list";
@@ -11,6 +11,7 @@ import { ROUTE_SCENE_ADD } from "src/constants/route";
 
 const Scenes: FC = () => {
   const auth = useContext(AuthContext);
+  const { data: configData } = useConfig();
   const [{ fingerprint }] = useQueryParams({
     fingerprint: { name: "fingerprint", type: "string" },
   });
@@ -27,7 +28,7 @@ const Scenes: FC = () => {
     <>
       <div className="d-flex">
         <h3 className="me-4">Scenes</h3>
-        {canEdit(auth.user) && (
+        {canEdit(auth.user) && !configData?.getConfig.require_scene_draft && (
           <Link to={createHref(ROUTE_SCENE_ADD)} className="ms-auto">
             <Button>Create</Button>
           </Link>

graphql/schema/types/config.graphql

@@ -8,4 +8,5 @@ type StashBoxConfig {
   min_destructive_voting_period: Int!
   vote_cron_interval: String!
   guidelines_url: String!
+  require_scene_draft: Boolean!
 }

pkg/api/resolver.go

@@ -119,5 +119,6 @@ func (r *queryResolver) GetConfig(ctx context.Context) (*models.StashBoxConfig,
 		MinDestructiveVotingPeriod: config.GetMinDestructiveVotingPeriod(),
 		VoteCronInterval:           config.GetVoteCronInterval(),
 		GuidelinesURL:              config.GetGuidelinesURL(),
+		RequireSceneDraft:          config.GetRequireSceneDraft(),
 	}, nil
 }

pkg/api/resolver_mutation_edit.go

@@ -17,6 +17,7 @@ var ErrUnauthorizedUpdate = fmt.Errorf("Only the creator can update edits")
 var ErrClosedEdit = fmt.Errorf("Votes can only be cast on pending edits")
 var ErrUnauthorizedBot = fmt.Errorf("You do not have permission to submit bot edits")
 var ErrUpdateLimit = fmt.Errorf("Edit update limit reached")
+var ErrSceneDraftRequired = fmt.Errorf("Scenes have to be submitted through drafts")
 
 func (r *mutationResolver) SceneEdit(ctx context.Context, input models.SceneEditInput) (*models.Edit, error) {
 	UUID, err := uuid.NewV4()
@@ -33,6 +34,17 @@ func (r *mutationResolver) SceneEdit(ctx context.Context, input models.SceneEdit
 	newEdit := models.NewEdit(UUID, currentUser, models.TargetTypeEnumScene, input.Edit)
 
 	fac := r.getRepoFactory(ctx)
+	if config.GetRequireSceneDraft() {
+		if input.Details != nil && input.Details.DraftID != nil {
+			draft, err := fac.Draft().Find(*input.Details.DraftID)
+			if err != nil || draft == nil {
+				return nil, ErrSceneDraftRequired
+			}
+		} else {
+			return nil, ErrSceneDraftRequired
+		}
+	}
+
 	err = fac.WithTxn(func() error {
 		p := edit.Scene(fac, newEdit)
 		inputArgs := utils.Arguments(ctx).Field("input")

pkg/manager/config/config.go

@@ -60,6 +60,8 @@ type config struct {
 	VoteCronInterval string `mapstructure:"vote_cron_interval"`
 	// Number of times an edit can be updated by the creator
 	EditUpdateLimit int `mapstructure:"edit_update_limit"`
+	// Require all scene create edits to be submitted via drafts
+	RequireSceneDraft bool `mapstructure:"require_scene_draft"`
 
 	// Email settings
 	EmailHost string `mapstructure:"email_host"`
@@ -123,6 +125,7 @@ var C = &config{
 	MinDestructiveVotingPeriod: 172800,
 	DraftTimeLimit:             86400,
 	EditUpdateLimit:            1,
+	RequireSceneDraft:          false,
 }
 
 func GetDatabasePath() string {
@@ -375,6 +378,10 @@ func GetEditUpdateLimit() int {
 	return C.EditUpdateLimit
 }
 
+func GetRequireSceneDraft() bool {
+	return C.RequireSceneDraft
+}
+
 func GetTitle() string {
 	if C.Title == "" {
 		return "Stash-Box"