Refactor image resizing #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes previous image resizing infrastructure in favor of JIT resizing via libvips. The upside is we can use thumbs of different sizes rather using 720p/1080p images for everything.
This requires CGO for linux, which breaks static linking on linux. It's proven very difficult to sort out on Windows, so the windows build will continue using the rather slow go resizing. As long as production builds use docker, it shouldn't cause any issues.
Overall it's pretty speedy, although for production I recommend using varnish or similar to cache.